<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20890">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports<br><br>This allows the use of the native VGA init on boards featuring DVI-I<br>ports.<br><br>TODO: check if the display is actually an analog display.<br><br>Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/x4x/gma.c<br>1 file changed, 11 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/20890/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c<br>index e91d778..a71ef83 100644<br>--- a/src/northbridge/intel/x4x/gma.c<br>+++ b/src/northbridge/intel/x4x/gma.c<br>@@ -74,6 +74,15 @@<br>       u32 pixel_m1 = 1;<br>     u32 pixel_m2 = 1;<br> <br>+ vga_gmbus = GMBUS_PORT_VGADDC;<br>+<br>+    if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_B))<br>+           vga_gmbus = GMBUS_PORT_DPB;<br>+  else if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_C))<br>+              vga_gmbus = GMBUS_PORT_DPC;<br>+  else if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_D))<br>+              vga_gmbus = GMBUS_PORT_DPD;<br>+<br>        vga_gr_write(0x18, 0);<br> <br>     /* Set up GTT */<br>@@ -113,7 +122,8 @@<br> <br>      udelay(1);<br> <br>-        intel_gmbus_read_edid(mmio + GMBUS0, GMBUS_PORT_VGADDC, 0x50, edid_data,<br>+     /* FIXME: check if it is actually an analog display */<br>+       intel_gmbus_read_edid(mmio + GMBUS0, vga_gmbus, 0x50, edid_data,<br>                      sizeof(edid_data));<br>   intel_gmbus_stop(mmio + GMBUS0);<br>      decode_edid(edid_data,<br></pre><p>To view, visit <a href="https://review.coreboot.org/20890">change 20890</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20890"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515 </div>
<div style="display:none"> Gerrit-Change-Number: 20890 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>