[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/lpss: Add lpss_is_controller_in_reset

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/20885


Change subject: soc/intel/common/lpss: Add lpss_is_controller_in_reset
......................................................................

soc/intel/common/lpss: Add lpss_is_controller_in_reset

Add new API function lpss_is_controller_in_reset that returns whether
the LPSS controller is in reset. Also, add lpss.c to smm stage so that
lpss_is_controller_in_reset can be used in smihandler.

BUG=b:64030366

Change-Id: I0fe5c2890ee799b08482e487296a483fa8d42461
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/soc/intel/common/block/include/intelblocks/lpss.h
M src/soc/intel/common/block/lpss/Makefile.inc
M src/soc/intel/common/block/lpss/lpss.c
3 files changed, 15 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/20885/1

diff --git a/src/soc/intel/common/block/include/intelblocks/lpss.h b/src/soc/intel/common/block/include/intelblocks/lpss.h
index 03a4714..138340d 100644
--- a/src/soc/intel/common/block/include/intelblocks/lpss.h
+++ b/src/soc/intel/common/block/include/intelblocks/lpss.h
@@ -27,4 +27,7 @@
  */
 void lpss_clk_update(uintptr_t base, uint32_t clk_m_val, uint32_t clk_n_val);
 
+/* Check if controller is in reset. */
+bool lpss_is_controller_in_reset(uintptr_t base);
+
 #endif	/* SOC_INTEL_COMMON_BLOCK_LPSS_H */
diff --git a/src/soc/intel/common/block/lpss/Makefile.inc b/src/soc/intel/common/block/lpss/Makefile.inc
index 50d1c10..6ed654f 100644
--- a/src/soc/intel/common/block/lpss/Makefile.inc
+++ b/src/soc/intel/common/block/lpss/Makefile.inc
@@ -2,3 +2,4 @@
 romstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_LPSS) += lpss.c
 verstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_LPSS) += lpss.c
 ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_LPSS) += lpss.c
+smm-$(CONFIG_SOC_INTEL_COMMON_BLOCK_LPSS) += lpss.c
diff --git a/src/soc/intel/common/block/lpss/lpss.c b/src/soc/intel/common/block/lpss/lpss.c
index 146fdab..feacef3 100644
--- a/src/soc/intel/common/block/lpss/lpss.c
+++ b/src/soc/intel/common/block/lpss/lpss.c
@@ -39,6 +39,17 @@
 /* DMA Software Reset Control */
 #define LPSS_DMA_RST_RELEASE	(1 << 2)
 
+bool lpss_is_controller_in_reset(uintptr_t base)
+{
+	uint8_t *addr = (void *)base;
+	uint32_t val = read32(addr + LPSS_RESET_CTL_REG);
+
+	if (val == 0xFFFFFFFF)
+		return true;
+
+	return !(val & LPSS_CNT_RST_RELEASE);
+}
+
 void lpss_reset_release(uintptr_t base)
 {
 	uint8_t *addr = (void *)base;

-- 
To view, visit https://review.coreboot.org/20885
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fe5c2890ee799b08482e487296a483fa8d42461
Gerrit-Change-Number: 20885
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170805/01d5e276/attachment.html>