[coreboot-gerrit] Change in coreboot[master]: crossgcc: fix DESTDIR builds

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Apr 27 18:11:27 CEST 2017


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19463 )

Change subject: crossgcc: fix DESTDIR builds
......................................................................


crossgcc: fix DESTDIR builds

We need to rewrite libtool's files (foo.la) a couple of times so it
knows where to look
(while still whining that $DESTDIR$TARGET != $TARGET. well, duh.)

Change-Id: I54cafd47c76d855222ba905b5eb4533a23bdfd34
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Reviewed-on: https://review.coreboot.org/19463
Tested-by: build bot (Jenkins)
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
M util/crossgcc/buildgcc
1 file changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Philippe Mathieu-Daudé: Looks good to me, but someone else must approve
  Stefan Reinauer: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 3ebde85..9239b5d 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -534,7 +534,7 @@
 
 	# work around build problem of libgmp.la
 	if [ "$DESTDIR" != "" ]; then
-	    perl -pi -e "s,$DESTDIR,," $DESTDIR$TARGETDIR/libgmp.la
+	    perl -pi -e "s,$DESTDIR,," $DESTDIR$TARGETDIR/lib/libgmp.la
 	fi
 }
 
@@ -543,9 +543,20 @@
 		--infodir=$TARGETDIR/info --with-mpfr=$DESTDIR$TARGETDIR \
 		--with-gmp=$DESTDIR$TARGETDIR CFLAGS="$HOSTCFLAGS" || \
 		touch .failed
+
+	# work around build problem of libmpfr.la
+	if [ "$DESTDIR" != "" ]; then
+	    perl -pi -e "s,$TARGETDIR/lib/libgmp.la,$DESTDIR\$&," $DESTDIR$TARGETDIR/lib/libmpfr.la
+	fi
+
 	$MAKE $JOBS || touch .failed
 	$MAKE install DESTDIR=$DESTDIR || touch .failed
 
+	# work around build problem of libmpfr.la
+	if [ "$DESTDIR" != "" ]; then
+	    perl -pi -e "s,$DESTDIR,," $DESTDIR$TARGETDIR/lib/libmpfr.la
+	fi
+
 	normalize_dirs
 }
 

-- 
To view, visit https://review.coreboot.org/19463
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54cafd47c76d855222ba905b5eb4533a23bdfd34
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer at chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list