[coreboot-gerrit] Change in coreboot[master]: crossgcc: fix DESTDIR builds

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19463 )

Change subject: crossgcc: fix DESTDIR builds
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19463/1/util/crossgcc/buildgcc
File util/crossgcc/buildgcc:

PS1, Line 549: \$&
> tricky perl...
Yeah, things like this are the reason people hate perl (and makefiles)
We could use "s,($TARGETDIR/lib/libgmp.la),$DESTDIR\$1,"
or we could use perl -MEnglish and use \$Match instead of \$&.


-- 
To view, visit https://review.coreboot.org/19463
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54cafd47c76d855222ba905b5eb4533a23bdfd34
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer at chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes