[coreboot-gerrit] Change in coreboot[master]: Kconfig: provide MAINBOARD_HAS_TPM_CR50 option

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19370 )

Change subject: Kconfig: provide MAINBOARD_HAS_TPM_CR50 option
......................................................................


Patch Set 3:

I'm a little confused by that output (are those all the relevant lines?). It ultimately seems to complain that it doesn't have TPM2 enabled, but just the line before that is says that TPM2 got selected (by VBOOT, presumably)? (Is this the CHROMEOS or the non-CHROMEOS build?)

Either way, maybe it can be resolved by reordering Dan's patch "drivers/spi/tpm: Do not let MAINBOARD_HAS_SPI_TPM_CR50 depend on SPI_TPM" to the front (that would at least break one link in that chain)?

-- 
To view, visit https://review.coreboot.org/19370
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I878f9b9dc99cfb0252d6fef7fc020fa3d391fcec
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No