[coreboot-gerrit] Change in coreboot[master]: Kconfig: provide MAINBOARD_HAS_TPM_CR50 option

Martin Roth (Code Review) gerrit at coreboot.org
Mon Apr 24 19:41:28 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/19370 )

Change subject: Kconfig: provide MAINBOARD_HAS_TPM_CR50 option
......................................................................


Patch Set 3:

We had a lot of failures in Kconfig generation, which don't show up in the output log.  I'll work on fixing that.

GOOGLE_GRU config creation FAILED!
GOOGLE_SCARLET config creation FAILED!
GOOGLE_BOB config creation FAILED!
...

Log excerpt:
src/Kconfig:296: symbol MAINBOARD_HAS_TPM2 is selected by MAINBOARD_HAS_TPM_CR50
src/Kconfig:407: symbol MAINBOARD_HAS_TPM_CR50 depends on MAINBOARD_HAS_SPI_TPM_CR50
src/drivers/spi/tpm/Kconfig:15: symbol MAINBOARD_HAS_SPI_TPM_CR50 depends on SPI_TPM
src/drivers/spi/tpm/Kconfig:1: symbol SPI_TPM depends on TPM2
src/Kconfig:396: symbol TPM2 is selected by MAINBOARD_HAS_TPM2
warning: (POPPY_USE_SPI_TPM && VBOOT) selects SPI_TPM which has unmet direct dependencies (TPM2)

-- 
To view, visit https://review.coreboot.org/19370
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I878f9b9dc99cfb0252d6fef7fc020fa3d391fcec
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list