[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Re-factor spi_crop_chunk

[Philippe Mathieu-Daudé (Code Review)]

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19386 )

Change subject: drivers/spi: Re-factor spi_crop_chunk
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://review.coreboot.org/#/c/19386/2/src/include/spi-generic.h
File src/include/spi-generic.h:

PS2, Line 91: contoller
you can fix this tipo while here :)


PS2, Line 99: (0 = No limit)
what about using UINTMAX_MAX for no limit to make it more explicit?


PS2, Line 113: deduct_cmd_len
thinking about someone implementing a new SPI controller using max_xfer_size bug forgetting to initialize deduct_cmd_len... should we check (max_xfer_size && !deduct_cmd_len) and/or (!max_xfer_size && deduct_cmd_len) somewhere? ( probably spi_setup_slave() )


-- 
To view, visit https://review.coreboot.org/19386
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81c199413f879c664682088e93bfa3f91c6a46e5
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes