[coreboot-gerrit] Change in coreboot[master]: google/oak: Use edid_set_framebuffer_bits_per_pixel

[Daniel Kurtz (Code Review)]

Hello Daniel Kurtz,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/19388

to review the following change.


Change subject: google/oak: Use edid_set_framebuffer_bits_per_pixel
......................................................................

google/oak: Use edid_set_framebuffer_bits_per_pixel

This helper function was introduced o that mainboards don't need
to manually fill in these struct edid fields.

BRANCH=none
BUG=b:35774871
TEST=Boot Rowan in developer mode and see output on the panel

Change-Id: Ic9404a786a28b314b710e037dcae776be4b584ca
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/mainboard/google/oak/mainboard.c
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/19388/1

diff --git a/src/mainboard/google/oak/mainboard.c b/src/mainboard/google/oak/mainboard.c
index 7cb6a68..2e17678 100644
--- a/src/mainboard/google/oak/mainboard.c
+++ b/src/mainboard/google/oak/mainboard.c
@@ -229,10 +229,7 @@
 		return;
 	}
 
-	edid.x_resolution = edid.mode.ha;
-	edid.y_resolution = edid.mode.va;
-	edid.bytes_per_line = edid.mode.ha * edid.framebuffer_bits_per_pixel /
-			      8;
+	edid_set_framebuffer_bits_per_pixel(&edid, 32, 0);
 
 	mtk_ddp_init();
 	ret = mtk_dsi_init(MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE,

-- 
To view, visit https://review.coreboot.org/19388
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9404a786a28b314b710e037dcae776be4b584ca
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>