[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/tpm/cr50: Use tis_plat_irq_status for Cr50 irq s...

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/19363 )

Change subject: drivers/i2c/tpm/cr50: Use tis_plat_irq_status for Cr50 irq status
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/19363/1//COMMIT_MSG
Commit Message:

PS1, Line 25: drive
> driver
Done


Line 42: Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
> Please move this line directly below the Change-Id line.
Done


https://review.coreboot.org/#/c/19363/1/src/drivers/i2c/tpm/cr50.c
File src/drivers/i2c/tpm/cr50.c:

PS1, Line 471: 	/* Disable TPM 1.2-style command complete interrupt (not supported) */
             : 	chip->vendor.irq = 0;
> This isn't needed. We're already clearing the entire structure in cr50_vend
Done


https://review.coreboot.org/#/c/19363/1/src/drivers/i2c/tpm/tpm.h
File src/drivers/i2c/tpm/tpm.h:

PS1, Line 61: 	int irq;
> This irq field can be completely nuked as well. No other user exists. The '
My understanding is the "if (chip->vendor.irq)" path is for the TPM 1.2 "command completion" irq.  

TPM 2.0 devices (or at least Cr50) will just leave this irq as 0, and therefore do the polling-on-status wait in tpm_transmit().

Removing vendor.irq may be a useful cleanup if there are really no older tpms that use this, but it seems orthogonal to adding TPM 2.0 support, and can be done later.


https://review.coreboot.org/#/c/19363/1/src/mainboard/google/eve/Kconfig
File src/mainboard/google/eve/Kconfig:

PS1, Line 43: 
> With https://review.coreboot.org/#/c/19369/ this config can just be renamed
Done


-- 
To view, visit https://review.coreboot.org/19363
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I004329eae1d8aabda51c46b8504bf210484782b4
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes