[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/tpm/cr50: Use tis_plat_irq_status for Cr50 irq s...

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/19363 )

Change subject: drivers/i2c/tpm/cr50: Use tis_plat_irq_status for Cr50 irq status
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19363/1/src/drivers/i2c/tpm/tpm.h
File src/drivers/i2c/tpm/tpm.h:

PS1, Line 61: 
This should really be removed as well, and the logic that tries to use it in tis.c


https://review.coreboot.org/#/c/19363/1/src/mainboard/google/eve/chromeos.c
File src/mainboard/google/eve/chromeos.c:

Line 64: }
> The location of this function should not be conditionally compiled in based
Could we define this in soc/intel/common somewhere and get the gpe number from kconfig or devicetree?  This level of flexibility just makes one more step in a new board port when the reality is that all intel products are going to use GPE for this.


-- 
To view, visit https://review.coreboot.org/19363
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I004329eae1d8aabda51c46b8504bf210484782b4
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes