[coreboot-gerrit] Change in coreboot[master]: soc/intel/quark: Move include of reg_access.h
Lee Leahy (Code Review)
gerrit at coreboot.org
Wed Apr 19 20:54:07 CEST 2017
Lee Leahy has submitted this change and it was merged. ( https://review.coreboot.org/19355 )
Change subject: soc/intel/quark: Move include of reg_access.h
......................................................................
soc/intel/quark: Move include of reg_access.h
Move include of reg_access.h from pci_devs.h to reg_access.c.
TEST=Build and run on Galileo Gen2
Change-Id: I0d2de96f51c56001cdd06c7974cbc649fde1e89c
Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
Reviewed-on: https://review.coreboot.org/19355
Tested-by: build bot (Jenkins)
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
---
M src/soc/intel/quark/include/soc/pci_devs.h
M src/soc/intel/quark/reg_access.c
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sumeet R Pawnikar: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/soc/intel/quark/include/soc/pci_devs.h b/src/soc/intel/quark/include/soc/pci_devs.h
index 2ddc214..fc28dfe 100644
--- a/src/soc/intel/quark/include/soc/pci_devs.h
+++ b/src/soc/intel/quark/include/soc/pci_devs.h
@@ -20,7 +20,6 @@
#include <device/pci.h>
#include <device/pci_def.h>
-#include <soc/reg_access.h>
/* DEVICE 0 (Memory Controller Hub) */
#define MC_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, MC_DEV, MC_FUN)
diff --git a/src/soc/intel/quark/reg_access.c b/src/soc/intel/quark/reg_access.c
index 5c4629b..867a431 100644
--- a/src/soc/intel/quark/reg_access.c
+++ b/src/soc/intel/quark/reg_access.c
@@ -20,6 +20,7 @@
#include <console/console.h>
#include <soc/pci_devs.h>
#include <soc/ramstage.h>
+#include <soc/reg_access.h>
static uint16_t get_gpe0_address(uint32_t reg_address)
{
--
To view, visit https://review.coreboot.org/19355
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d2de96f51c56001cdd06c7974cbc649fde1e89c
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list