[coreboot-gerrit] Change in coreboot[master]: google/gru: change center logic voltage to 900mV

[Julius Werner (Code Review)]

Hello Lin Huang, Patrick Georgi,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/19356

to review the following change.


Change subject: google/gru: change center logic voltage to 900mV
......................................................................

google/gru: change center logic voltage to 900mV

It seems that we should only ever run at 900mV on center logic.
Changing it to 950mV before might have just masked over problems that
are now fixed.

BRANCH=none
BUG=chrome-os-partner:56940
TEST=on kevin, run
stressapptest -M 1536 -s 1000

Change-Id: I5a09b1b403df800396bb2f2e8c76d14a4519d44a
Signed-off-by: Derek Basehore <dbasehore at chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/391032
Reviewed-by: Douglas Anderson <dianders at chromium.org>
Commit-Queue: Lin Huang <hl at rock-chips.com>
Tested-by: Lin Huang <hl at rock-chips.com>
---
M src/mainboard/google/gru/romstage.c
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/19356/1

diff --git a/src/mainboard/google/gru/romstage.c b/src/mainboard/google/gru/romstage.c
index 7f84a2a..4ea5318 100644
--- a/src/mainboard/google/gru/romstage.c
+++ b/src/mainboard/google/gru/romstage.c
@@ -21,6 +21,7 @@
 #include <cbfs.h>
 #include <cbmem.h>
 #include <console/console.h>
+#include <delay.h>
 #include <program_loading.h>
 #include <romstage_handoff.h>
 #include <soc/addressmap.h>
@@ -37,7 +38,9 @@
 {
 	pwm_regulator_configure(PWM_REGULATOR_GPU, 900);
 	pwm_regulator_configure(PWM_REGULATOR_BIG, 900);
-	pwm_regulator_configure(PWM_REGULATOR_CENTERLOG, 950);
+	pwm_regulator_configure(PWM_REGULATOR_CENTERLOG, 900);
+	/* Allow time for the regulators to settle */
+	udelay(500);
 }
 
 static void prepare_usb(void)

-- 
To view, visit https://review.coreboot.org/19356
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a09b1b403df800396bb2f2e8c76d14a4519d44a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>