[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Add camera support
Martin Roth (Code Review)
gerrit at coreboot.org
Wed Apr 19 16:23:18 CEST 2017
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18969 )
Change subject: mb/google/poppy: Add camera support
......................................................................
mb/google/poppy: Add camera support
Add camera related support
* Enable the SA Imaging Unit and CIO2 devices.
* Enable TPS68470 PMIC and populate related ACPI objects.
* Enable OV cameras and populate related ACPI objects.
* Enable Dongwoon AF DAC and populate related ACPI objects.
BUG=b:36580624
BRANCH=none
TEST=Build and boot poppy. Dump and verify that ACPI tables
have the required entries for all the camera devices.
Change-Id: Ifbe878bb6b25fc976e935fee16c4d59fadd47fe2
Signed-off-by: Sowmya V <v.sowmya at intel.com>
Signed-off-by: Rizwan Qureshi <rizwan.qureshi at intel.com>
Reviewed-on: https://review.coreboot.org/18969
Tested-by: build bot (Jenkins)
Reviewed-by: Furquan Shaikh <furquan at google.com>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/devicetree.cb
2 files changed, 136 insertions(+), 3 deletions(-)
Approvals:
Sumeet R Pawnikar: Looks good to me, approved
build bot (Jenkins): Verified
Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 0626a32..bc0c9cb 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -4,6 +4,7 @@
def_bool y
select BOARD_ID_AUTO
select BOARD_ROMSIZE_KB_16384
+ select DRIVERS_INTEL_MIPI_CAMERA
select DRIVERS_I2C_GENERIC
select DRIVERS_I2C_HID
select EC_GOOGLE_CHROMEEC
diff --git a/src/mainboard/google/poppy/devicetree.cb b/src/mainboard/google/poppy/devicetree.cb
index c714d0b..d232028 100644
--- a/src/mainboard/google/poppy/devicetree.cb
+++ b/src/mainboard/google/poppy/devicetree.cb
@@ -38,7 +38,8 @@
register "XdciEnable" = "0"
register "SsicPortEnable" = "0"
register "SmbusEnable" = "1"
- register "Cio2Enable" = "0"
+ register "Cio2Enable" = "1"
+ register "SaImguEnable" = "1"
register "ScsEmmcEnabled" = "1"
register "ScsEmmcHs400Enabled" = "1"
register "ScsSdCardEnabled" = "2"
@@ -207,7 +208,84 @@
end
end # I2C #0
device pci 15.1 on end # I2C #1
- device pci 15.2 on end # I2C #2
+ device pci 15.2 on
+ chip drivers/intel/mipi_camera
+ register "acpi_hid" = ""INT3472""
+ register "acpi_name" = ""PMIC""
+ register "chip_name" = ""TPS68470 PMIC""
+ register "device_type" = "INTEL_ACPI_CAMERA_PMIC"
+ device i2c 4d on end
+ end
+ chip drivers/intel/mipi_camera
+ register "acpi_hid" = ""OVTID850""
+ register "acpi_name" = ""CAM0""
+ register "chip_name" = ""OV 13850 Camera""
+ register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
+
+ # Camera SSDB buffer
+ register "ssdb.sensor_card_sku" = "0x50"
+ register "ssdb.link_used" = "0x00"
+ register "ssdb.lanes_used" = "0x04"
+ register "ssdb.rom_type" = "0x08"
+ register "ssdb.vcm_type" = "0x03"
+ register "ssdb.platform" = "0x09"
+ register "ssdb.flash_support" = "0x02"
+ register "ssdb.privacy_led" = "0x01"
+ register "ssdb.degree" = "0x00"
+ register "ssdb.mipi_define" = "0x01"
+ register "ssdb.mclk" = "0x016E3600"
+
+ # Sensor PWDB entries
+ register "num_pwdb_entries" = "5"
+
+ register "pwdb[0].name" = ""VSIO""
+ register "pwdb[0].value" = "1800600"
+ register "pwdb[0].entry_type" = "INTEL_ACPI_CAMERA_REGULATOR"
+ register "pwdb[0].delay_usec" = "0"
+
+ register "pwdb[1].name" = ""tps68470-a""
+ register "pwdb[1].value" = "19200000"
+ register "pwdb[1].entry_type" = "INTEL_ACPI_CAMERA_CLK"
+ register "pwdb[1].delay_usec" = "0"
+
+ register "pwdb[2].name" = ""ANA""
+ register "pwdb[2].value" = "2815200"
+ register "pwdb[2].entry_type" = "INTEL_ACPI_CAMERA_REGULATOR"
+ register "pwdb[2].delay_usec" = "3000"
+
+ register "pwdb[3].name" = ""s_resetn""
+ register "pwdb[3].value" = "1"
+ register "pwdb[3].entry_type" = "INTEL_ACPI_CAMERA_GPIO"
+ register "pwdb[3].delay_usec" = "0"
+
+ register "pwdb[4].name" = ""CORE""
+ register "pwdb[4].value" = "1200000"
+ register "pwdb[4].entry_type" = "INTEL_ACPI_CAMERA_REGULATOR"
+ register "pwdb[4].delay_usec" = "3000"
+
+ device i2c 10 on end
+ end
+ chip drivers/intel/mipi_camera
+ register "acpi_hid" = ""DW9714""
+ register "acpi_name" = ""VCM0""
+ register "chip_name" = ""Dongwoon AF DAC""
+ register "device_type" = "INTEL_ACPI_CAMERA_VCM"
+
+ # VCM PWDB entries
+ register "num_pwdb_entries" = "2"
+ register "pwdb[0].name" = ""VSIO""
+ register "pwdb[0].value" = "1800600"
+ register "pwdb[0].entry_type" = "INTEL_ACPI_CAMERA_REGULATOR"
+ register "pwdb[0].delay_usec" = "0"
+
+ register "pwdb[1].name" = ""VCM""
+ register "pwdb[1].value" = "2815200"
+ register "pwdb[1].entry_type" = "INTEL_ACPI_CAMERA_REGULATOR"
+ register "pwdb[1].delay_usec" = "3000"
+
+ device i2c 0xc on end
+ end
+ end # I2C #2
device pci 15.3 on
chip drivers/i2c/hid
register "generic.hid" = ""WCOM50C1""
@@ -248,7 +326,61 @@
device i2c 13 on end
end
end # I2C #5
- device pci 19.2 on end # I2C #4
+ device pci 19.2 on
+ chip drivers/intel/mipi_camera
+ register "acpi_hid" = ""INT3479""
+ register "acpi_name" = ""CAM1""
+ register "chip_name" = ""OV 5670 Camera""
+ register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
+
+ # Camera SSDB buffer
+ register "ssdb.sensor_card_sku" = "0x50"
+ register "ssdb.link_used" = "0x01"
+ register "ssdb.lanes_used" = "0x02"
+ register "ssdb.rom_type" = "0x08"
+ register "ssdb.vcm_type" = "0x03"
+ register "ssdb.platform" = "0x09"
+ register "ssdb.flash_support" = "0x02"
+ register "ssdb.privacy_led" = "0x01"
+ register "ssdb.mipi_define" = "0x01"
+ register "ssdb.mclk" = "0x016E3600"
+
+ # Sensor PWDB entries
+ register "num_pwdb_entries" = "6"
+
+ register "pwdb[0].name" = ""VSIO""
+ register "pwdb[0].value" = "1800600"
+ register "pwdb[0].entry_type" = "INTEL_ACPI_CAMERA_REGULATOR"
+ register "pwdb[0].delay_usec" = "0"
+
+ register "pwdb[1].name" = ""AUX2""
+ register "pwdb[1].value" = "1800600"
+ register "pwdb[1].entry_type" = "INTEL_ACPI_CAMERA_REGULATOR"
+ register "pwdb[1].delay_usec" = "0"
+
+ register "pwdb[2].name" = ""tps68470-b""
+ register "pwdb[2].value" = "19200000"
+ register "pwdb[2].entry_type" = "INTEL_ACPI_CAMERA_CLK"
+ register "pwdb[2].delay_usec" = "0"
+
+ register "pwdb[3].name" = ""gpio.4""
+ register "pwdb[3].value" = "1"
+ register "pwdb[3].entry_type" = "INTEL_ACPI_CAMERA_GPIO"
+ register "pwdb[3].delay_usec" = "3000"
+
+ register "pwdb[4].name" = ""gpio.5""
+ register "pwdb[4].value" = "1"
+ register "pwdb[4].entry_type" = "INTEL_ACPI_CAMERA_GPIO"
+ register "pwdb[4].delay_usec" = "0"
+
+ register "pwdb[5].name" = ""AUX1""
+ register "pwdb[5].value" = "1213200"
+ register "pwdb[5].entry_type" = "INTEL_ACPI_CAMERA_REGULATOR"
+ register "pwdb[5].delay_usec" = "3000"
+
+ device i2c 10 on end
+ end
+ end # I2C #4
device pci 1c.0 on
chip drivers/intel/wifi
register "wake" = "GPE0_PCI_EXP"
--
To view, visit https://review.coreboot.org/18969
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbe878bb6b25fc976e935fee16c4d59fadd47fe2
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list