[coreboot-gerrit] Change in coreboot[master]: amd/pi/mainboards: Consolidate early duplicated code

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18434 )

Change subject: amd/pi/mainboards: Consolidate early duplicated code
......................................................................


Patch Set 11:

(5 comments)

https://review.coreboot.org/#/c/18434/11/src/cpu/amd/pi/00660F01/fixme.c
File src/cpu/amd/pi/00660F01/fixme.c:

PS11, Line 98: Mask bit
> mask off?
I don't have any visibility into what that is.  I kept the existing comment.  This patch was only rearranging things.


https://review.coreboot.org/#/c/18434/11/src/cpu/amd/pi/car.c
File src/cpu/amd/pi/car.c:

PS11, Line 54: car_
> Why is this function prefixed with 'car_' ? It doesn't have anything to do 
Same reason as car_sb_pre_console_init, car_mainboard_pre_console_init, etc.  Was trying to match the style of the patch I was duplicating as much as possible.

Since we hope to move away from this ASAP, I'll hold off on changing the names for now.


https://review.coreboot.org/#/c/18434/11/src/mainboard/amd/db-ft3b-lc/early_mainboard.c
File src/mainboard/amd/db-ft3b-lc/early_mainboard.c:

Line 30: 	outb(0x00, 0xcd7);
> 0xcd6 -> PM_INDEX
Agreed.  This was only cut/paste, as I thought I'd get a lot of grief for too many modifications.


https://review.coreboot.org/#/c/18434/11/src/mainboard/amd/olivehillplus/early_mainboard.c
File src/mainboard/amd/olivehillplus/early_mainboard.c:

Line 40: 	{
> Why put this in a block?
Cut/paste.  I looked at the gerrit history for this -- it looks like it bounced back and forth blocked/not.  That's bad enough that I'll go ahead and change it...


https://review.coreboot.org/#/c/18434/11/src/mainboard/pcengines/apu2/early_mainboard.c
File src/mainboard/pcengines/apu2/early_mainboard.c:

Line 33: 	configure_gpio(ACPI_MMIO_BASE, IOMUX_GPIO_71, Function0, GPIO_71, setting);
> > 80
Cut/paste again.  Nit?  Or change it?


-- 
To view, visit https://review.coreboot.org/18434
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id10580ecc439df10df26ca99881772f328e7bdd0
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes