[coreboot-gerrit] Change in coreboot[master]: amd/pi/mainboards: Consolidate early duplicated code

[Marshall Dawson (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18434

to look at the new patch set (#12).

Change subject: amd/pi/mainboards: Consolidate early duplicated code
......................................................................

amd/pi/mainboards: Consolidate early duplicated code

Make a common entry function for cache_as_ram_main for use with the
PI-based mainboards.  The new function drives the typical setup, BIST
checking, product reporting, and other common functions.  This work
takes hints from commit e6af4be.

Add a new car.c file that contains the early steps.  This has
weak functions to hook for southbridge and mainboard setup.  Some
APUs also get BIST bits masked off.

This patch is intended to prepare for an upcoming change that will
split the CAR setup from the teardown, so that CAR setup may be used
in verstage.

Original-Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Original-Reviewed-by: Marc Jones <marcj303 at gmail.com>
(cherry picked from commit 9d1d92826216dee35f80ec40d722a3e8a587e996)

Change-Id: Id10580ecc439df10df26ca99881772f328e7bdd0
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/cpu/amd/pi/00660F01/fixme.c
M src/cpu/amd/pi/00670F00/fixme.c
M src/cpu/amd/pi/Makefile.inc
A src/cpu/amd/pi/car.c
A src/cpu/amd/pi/car.h
M src/mainboard/amd/bettong/romstage.c
M src/mainboard/amd/db-ft3b-lc/Makefile.inc
A src/mainboard/amd/db-ft3b-lc/early_mainboard.c
M src/mainboard/amd/db-ft3b-lc/romstage.c
M src/mainboard/amd/gardenia/romstage.c
M src/mainboard/amd/lamar/Makefile.inc
A src/mainboard/amd/lamar/early_mainboard.c
M src/mainboard/amd/lamar/romstage.c
M src/mainboard/amd/olivehillplus/Makefile.inc
A src/mainboard/amd/olivehillplus/early_mainboard.c
M src/mainboard/amd/olivehillplus/romstage.c
M src/mainboard/bap/ode_e21XX/Makefile.inc
A src/mainboard/bap/ode_e21XX/early_mainboard.c
M src/mainboard/bap/ode_e21XX/romstage.c
M src/mainboard/pcengines/apu2/Makefile.inc
A src/mainboard/pcengines/apu2/early_mainboard.c
M src/mainboard/pcengines/apu2/romstage.c
M src/southbridge/amd/pi/hudson/early_setup.c
M src/southbridge/amd/pi/hudson/hudson.h
24 files changed, 402 insertions(+), 317 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/18434/12
-- 
To view, visit https://review.coreboot.org/18434
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id10580ecc439df10df26ca99881772f328e7bdd0
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)