[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Add ChromeOS and Google EC

Marc Jones (Code Review) gerrit at coreboot.org
Fri Apr 14 18:57:49 CEST 2017


Marc Jones has posted comments on this change. ( https://review.coreboot.org/19164 )

Change subject: google/kahlee: Add ChromeOS and Google EC
......................................................................


Patch Set 7:

(2 comments)

build issue resolved... q vs g yay font and eye-test. Thanks Marshall.

https://review.coreboot.org/#/c/19164/7//COMMIT_MSG
Commit Message:

Line 7: google/kahlee: Add ChromeOS and Google EC
> Sure, the directory structure is google/ec and the CONFIG is GOOGLE_CHROMEE
The part isn't really relevant as the EC ABI abstracts that away, so it could be any supported EC. I'll add a comment that it is nuvoton and details are in the chromium ec repo.


Line 15: 
> Please elaborate how the FMD is configured.
Done


-- 
To view, visit https://review.coreboot.org/19164
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e442f5f880813e86dfd4918ecbed3eaa381f6cb
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list