[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Add ChromeOS and Google EC

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19164 )

Change subject: google/kahlee: Add ChromeOS and Google EC
......................................................................


Patch Set 7:

(2 comments)

Odd, this builds with my .config, but breaks here.

https://review.coreboot.org/#/c/19164/7//COMMIT_MSG
Commit Message:

Line 7: google/kahlee: Add ChromeOS and Google EC
> I believe is Chromium EC [1].
Sure, the directory structure is google/ec and the CONFIG is GOOGLE_CHROMEEC. I'll call it ChromeEC to match.


https://review.coreboot.org/#/c/19164/1/src/mainboard/google/kahlee/Kconfig
File src/mainboard/google/kahlee/Kconfig:

PS1, Line 61: select VBOOT_LID_SWITCH
> For chromeos chromeos.fmd will be used for CBFS size in which case it doesn
I've removed this since it is chromeos dependent. If we want the general case we should add it to the hudson makefile where the AMDFW_OUTSIDE_CBFS is set.


-- 
To view, visit https://review.coreboot.org/19164
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e442f5f880813e86dfd4918ecbed3eaa381f6cb
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes