[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add GPIO get function

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19159 )

Change subject: amd/pi/hudson: Add GPIO get function
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19159/1/src/southbridge/amd/pi/hudson/gpio.c
File src/southbridge/amd/pi/hudson/gpio.c:

Line 23: 
> Other coreboot gpio functions don't check. This would only be a partial cov
I'm not sure there is a solution for all gpio_get functions because they're all so different.  This one's different because it's actually expecting addresses to be passed in instead of just GPIO numbers.  The check I suggested just makes sure that we're reading from something inside the GPIO block, which I don't think is an unreasonable check.

I'll leave it up to you to decide if we should allow the GPIO functions to read from anywhere in memory or if they should be restricted to just the GPIO area.


-- 
To view, visit https://review.coreboot.org/19159
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f681865715ab947b525320a6f9fc63af1334b59
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes