[coreboot-gerrit] Change in coreboot[master]: cbmem: Add custom aligned memcpy() implementation
Julius Werner (Code Review)
gerrit at coreboot.org
Wed Apr 12 03:03:06 CEST 2017
Julius Werner has posted comments on this change. ( https://review.coreboot.org/18300 )
Change subject: cbmem: Add custom aligned memcpy() implementation
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/18300/2/util/cbmem/cbmem.c
File util/cbmem/cbmem.c:
Line 79: */
> Now that I look at this the compiler couldn't change it back if *s was read
Good idea actually, I can just cast the pointer to volatile to prevent the compiler from mucking with it. Let me do that...
--
To view, visit https://review.coreboot.org/18300
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03eece380a14a69d4be3805ed72fba640f6f7d9c
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list