[coreboot-gerrit] Change in coreboot[master]: cbmem: Add custom aligned memcpy() implementation

Patrick Georgi (Code Review) gerrit at coreboot.org
Tue Apr 11 07:45:55 CEST 2017


Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/18300 )

Change subject: cbmem: Add custom aligned memcpy() implementation
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18300/1/util/cbmem/cbmem.c
File util/cbmem/cbmem.c:

PS1, Line 66: never do unaligned accesses
> Uhh... what? Then this code will crash (with "assertion failed") when I try
erm, right. mixed up terminology (unaligned and natural accesses), my bad.


-- 
To view, visit https://review.coreboot.org/18300
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03eece380a14a69d4be3805ed72fba640f6f7d9c
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list