[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Add ChromeOS options

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19164 )

Change subject: google/kahlee: Add ChromeOS options
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19164/1/src/mainboard/google/kahlee/Kconfig
File src/mainboard/google/kahlee/Kconfig:

PS1, Line 61: default 0x00210000 if CHROMEOS
> Why is one specifying CBFS_SIZE at all?
It was to originally to accommodate this https://review.coreboot.org/#/c/18435/ , since CBFS_SIZE defaults to the flash size.  Now that you ask that though...  would futility simply defer to chromeos.fmd, maybe blow up if cbfs can't fit, and not necessarily care about CBFS_SIZE?


-- 
To view, visit https://review.coreboot.org/19164
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e442f5f880813e86dfd4918ecbed3eaa381f6cb
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes