[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Add ChromeOS options

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19164 )

Change subject: google/kahlee: Add ChromeOS options
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/19164/1/src/mainboard/google/kahlee/chromeos.c
File src/mainboard/google/kahlee/chromeos.c:

PS1, Line 22: #if ENV_RAMSTAGE
> Why?
Done


PS1, Line 38: int get_developer_mode_switch(void)
            : {
            : 	return 1;
            : }
> This can be removed. See https://review.coreboot.org/18980
Done


Line 59: {
> Use the common implementations in src/ec/google/chromeec. Most of these fun
It gets moved later in the EC patch. Martin also asked for a restructure of these two.


-- 
To view, visit https://review.coreboot.org/19164
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e442f5f880813e86dfd4918ecbed3eaa381f6cb
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes