[coreboot-gerrit] Change in coreboot[master]: google/eve: Limit memory SKU 5 to 1600MHz
Duncan Laurie (Code Review)
gerrit at coreboot.org
Tue Apr 11 04:04:29 CEST 2017
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/19227 )
Change subject: google/eve: Limit memory SKU 5 to 1600MHz
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19227/1/src/mainboard/google/eve/romstage.c
File src/mainboard/google/eve/romstage.c:
Line 53: printk(BIOS_WARNING, "Limiting memory to 1600MHz\n");
> Please add the word frequency in here. Also I think level *NOTICE* is fine,
MHz implies frequency, it really can't be anything else.
I made it warning specifically because this is NOT expected behavior at the moment.
--
To view, visit https://review.coreboot.org/19227
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02af7e9c35e2c5b0b85223d58025cbd29841d973
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list