[coreboot-gerrit] Change in coreboot[master]: util/blobtool: clean up blobtool.l a bit

Martin Roth (Code Review) gerrit at coreboot.org
Tue Apr 11 01:04:14 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19230

to look at the new patch set (#2).

Change subject: util/blobtool: clean up blobtool.l a bit
......................................................................

util/blobtool: clean up blobtool.l a bit

- Rewrite STRING and COMMENT expressions to remove need for CHARS.
- Clean up regular expressions - get rid of unnecessary expressions.
- Remove extra newline from the end of the file.

- Clean up stripquotes() function
-- Remove unnecessary backslashes in '\"'
-- Check malloc for failure
-- Remove unnecessary assignment of 0 to the end of the new string,
snprintf will take care of it.

- Update blobtool.lex.c_shipped to the new version.

Change-Id: I002962cfae0816ed3c7a5811dfb1b8b48fdc5729
Signed-off-by: Martin Roth <martinroth at google.com>
---
M util/blobtool/blobtool.l
M util/blobtool/blobtool.lex.c_shipped
2 files changed, 76 insertions(+), 110 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/19230/2
-- 
To view, visit https://review.coreboot.org/19230
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I002962cfae0816ed3c7a5811dfb1b8b48fdc5729
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list