[coreboot-gerrit] Change in coreboot[master]: util/blobtool: clean up blobtool.l a bit

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Apr 10 20:09:51 CEST 2017


Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19230 )

Change subject: util/blobtool: clean up blobtool.l a bit
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19230/1/util/blobtool/blobtool.l
File util/blobtool/blobtool.l:

Line 82: COMMENT [#]{CHAR}*[\n]
to avoid having to maintain the CHAR class, maybe just go for #.*$ or something like that?


-- 
To view, visit https://review.coreboot.org/19230
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I002962cfae0816ed3c7a5811dfb1b8b48fdc5729
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list