[coreboot-gerrit] Change in coreboot[master]: southbridge/via/vt8237r: Get rid of #include early_smbus.c

Lubomir Rintel (Code Review) gerrit at coreboot.org
Sun Apr 9 16:12:51 CEST 2017


Hello Arthur Heymans, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19082

to look at the new patch set (#4).

Change subject: southbridge/via/vt8237r: Get rid of #include early_smbus.c
......................................................................

southbridge/via/vt8237r: Get rid of #include early_smbus.c

Use linker instead of '#include *.c'.

The smbus_fixup() was changed not to use a structure that's defined by a
northbridge since multiple different northbridges can be used. Instead
the caller now directly passed the memory slot details.

Change-Id: Ia369ece6365accbc531736fc463c713bbc134807
Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
---
M src/mainboard/asus/a8v-e_deluxe/romstage.c
M src/mainboard/asus/a8v-e_se/romstage.c
M src/mainboard/asus/k8v-x/romstage.c
M src/mainboard/asus/m2v-mx_se/romstage.c
M src/mainboard/asus/m2v/romstage.c
M src/mainboard/bcom/winnetp680/romstage.c
M src/mainboard/jetway/j7f2/romstage.c
M src/mainboard/via/epia-cn/romstage.c
M src/mainboard/via/epia-m700/romstage.c
M src/mainboard/via/pc2500e/romstage.c
M src/southbridge/via/k8t890/early_car.c
M src/southbridge/via/vt8237r/Makefile.inc
M src/southbridge/via/vt8237r/early_smbus.c
M src/southbridge/via/vt8237r/vt8237r.h
14 files changed, 23 insertions(+), 20 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/19082/4
-- 
To view, visit https://review.coreboot.org/19082
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia369ece6365accbc531736fc463c713bbc134807
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list