[coreboot-gerrit] Change in coreboot[master]: southbridge/via/vt8237r: Get rid of #include early_smbus.c
Arthur Heymans (Code Review)
gerrit at coreboot.org
Tue Apr 4 19:08:12 CEST 2017
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19082 )
Change subject: southbridge/via/vt8237r: Get rid of #include early_smbus.c
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/19082/3/src/southbridge/via/vt8237r/early_smbus.c
File src/southbridge/via/vt8237r/early_smbus.c:
PS3, Line 224: smbus_fixup(const u8 channel0[], int ram_slots)
Maybe state in commit message that you changed the function argument (to make it more portable?)
--
To view, visit https://review.coreboot.org/19082
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia369ece6365accbc531736fc463c713bbc134807
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list