[coreboot-gerrit] Change in coreboot[master]: amd/pi/00670F00: Add generic romstage
Martin Roth (Code Review)
gerrit at coreboot.org
Thu Apr 6 22:35:28 CEST 2017
Martin Roth has posted comments on this change. ( https://review.coreboot.org/18495 )
Change subject: amd/pi/00670F00: Add generic romstage
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/18495/5/src/cpu/amd/pi/00670F00/romstage.c
File src/cpu/amd/pi/00670F00/romstage.c:
PS5, Line 42: /* Entry from the mainboard. */
: void romstage_common(void)
Why are you using a callback instead of just having it in cache_as_ram_stage_main after the call to mainboard_romstage_entry()?
--
To view, visit https://review.coreboot.org/18495
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If66ac0e4b3c088f138b9282546ed1ec2d861dd74
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list