[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: Add new port

[Ani Chang (Code Review)]

Ani Chang has posted comments on this change. ( https://review.coreboot.org/19079 )

Change subject: mainboard/lenovo/t410: Add new port
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/19079/4/src/mainboard/lenovo/t410/devicetree.cb
File src/mainboard/lenovo/t410/devicetree.cb:

Line 83: 	register "pci_mmio_size" = "1024"
> Most devices use 2048 to prevent problems with limited mmio space on dual g
> Most devices use 2048 to prevent problems with limited mmio space
 > on dual graphics

My T410 doesn't have dicrete nVIDIA GPU. Intel GMA only. And it is working with x201 coreboot flashed in...

1) add devicetree.cb at t410 variant?
2) add a note on the wiki saying it works for Intel GMA only t410s?
3) or .. ?


Line 88: 		end
> device pci 01.0 on # PEG is missing
I don't understand the issue you raised. Is a pci device missing?

The T410 has a Ricoh SD card reader, the x201 doesn't.
Have a look at lspci -nn here:

https://github.com/mfp19/coreboot-t410/wiki#X201_and_T410


-- 
To view, visit https://review.coreboot.org/19079
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80ea9ea4787c6cacf0640ce828bf083d616c91f9
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes