[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: Add new port

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19079 )

Change subject: mainboard/lenovo/t410: Add new port
......................................................................


Patch Set 4:

(2 comments)

Not sure if merge is possible, you have a different devicetree.

https://review.coreboot.org/#/c/19079/4/src/mainboard/lenovo/t410/devicetree.cb
File src/mainboard/lenovo/t410/devicetree.cb:

Line 83: 	register "pci_mmio_size" = "1024"
Most devices use 2048 to prevent problems with limited mmio space on dual graphics


Line 88: 		end
device pci 01.0 on # PEG is missing


-- 
To view, visit https://review.coreboot.org/19079
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80ea9ea4787c6cacf0640ce828bf083d616c91f9
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes