[coreboot-gerrit] Change in coreboot[master]: [WIP] mb/google/poppy: Add new DPTF parameters for Tablet mode

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/19087 )

Change subject: [WIP] mb/google/poppy: Add new DPTF parameters for Tablet mode
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19087/1/src/mainboard/google/poppy/acpi/dptf.asl
File src/mainboard/google/poppy/acpi/dptf.asl:

Line 56: 	Package () { 0, 0, 0, 0, 0, 0x000, "mA", 0 },	/* 0.0A */
> This was removed before. Why is it being added back?
I am not sure when it was removed earlier. This file is added part of https://review.coreboot.org/#/c/17926/ 

We need this to disable the charging completely when it breaches the temperature trip point for charger case. This will help to control the charger temperature.


-- 
To view, visit https://review.coreboot.org/19087
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68d0f7611c21157b7f4e35e504aafc7b0028551
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes