[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable XHCI clock gate control in ACPI

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18879 )

Change subject: soc/intel/skylake: Enable XHCI clock gate control in ACPI
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/18879/3/src/soc/intel/skylake/acpi/xhci.asl
File src/soc/intel/skylake/acpi/xhci.asl:

PS3, Line 133: 		/* Disable d3hot and SS link trunk clock gating */
             : 		Store(Zero, ^D3HE)
             : 		Store(Zero, ^STGE)
as i know, os may call _PS0 multiple time, which mean you will assign 0 to those register everytime, can't this be better managed?


PS3, Line 191: 		/* Enable d3hot and SS link trunk clock gating */
             :                 Store(One, ^D3HE)
             :                 Store(One, ^STGE)
-same


-- 
To view, visit https://review.coreboot.org/18879
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida2afa2e5f9404c0c15d7027480a28a003ad9a40
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rajat Jain <rajatja at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes