[coreboot-gerrit] Change in coreboot[master]: mainboard/intel: Fix checkpatch errors in minnowmax

Martin Roth (Code Review) gerrit at coreboot.org
Tue Apr 4 18:42:13 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/19078 )

Change subject: mainboard/intel: Fix checkpatch errors in minnowmax
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19078/1/src/mainboard/intel/minnowmax/gpio.c
File src/mainboard/intel/minnowmax/gpio.c:

PS1, Line 34: //
> I wouldn’t change the commenting style.
That was the way to get all the lines under 80 characters.


https://review.coreboot.org/#/c/19078/1/src/mainboard/intel/minnowmax/irqroute.h
File src/mainboard/intel/minnowmax/irqroute.h:

PS1, Line 25: 	
> while here you can probably remove this <tab> too
thanks.  missed that.


-- 
To view, visit https://review.coreboot.org/19078
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9afb50e268f4140872e39fe8bede231a43d5cc6
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list