[coreboot-gerrit] Change in coreboot[master]: mainboard/intel: Fix checkpatch errors in minnowmax
Martin Roth (Code Review)
gerrit at coreboot.org
Tue Apr 4 18:41:30 CEST 2017
Hello Philippe Mathieu-Daudé, Sumeet R Pawnikar, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19078
to look at the new patch set (#2).
Change subject: mainboard/intel: Fix checkpatch errors in minnowmax
......................................................................
mainboard/intel: Fix checkpatch errors in minnowmax
This fixes the following issues, with no functional changes:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
ERROR:SPACING: space required after that ',' (ctx:VxV)
WARNING:LONG_LINE_COMMENT: line over 80 characters
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition
ERROR:SPACING: space prohibited before that close parenthesis ')'
WARNING:RETURN_VOID: void function return statements are not generally
useful
2 unfixed issues:
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
Verified that the binary was the same before and after the changes.
Change-Id: Ie9afb50e268f4140872e39fe8bede231a43d5cc6
Signed-off-by: Martin Roth <gaumless at gmail.com>
---
M src/mainboard/intel/minnowmax/fadt.c
M src/mainboard/intel/minnowmax/gpio.c
M src/mainboard/intel/minnowmax/irqroute.h
M src/mainboard/intel/minnowmax/romstage.c
4 files changed, 197 insertions(+), 198 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/19078/2
--
To view, visit https://review.coreboot.org/19078
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie9afb50e268f4140872e39fe8bede231a43d5cc6
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list