[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: turned into a variant of x201

[Ani Chang (Code Review)]

Ani Chang has posted comments on this change. ( https://review.coreboot.org/19106 )

Change subject: mainboard/lenovo/t410: turned into a variant of x201
......................................................................


Patch Set 1:

> I think it's better to squash those together in one commit.

I'd like ... Yesterday I gave up when I realised that I was using the wrong git command to send the changes upstream.
I am currently fighting with eclipse mylyn and the rest of the stuff to integrate with Gerrit ... your project is too complicate to challenge it with vi and bare hands as usual :)

 > Also no need to create different dirs for this. look at how
 > macbook21 Kconfig are set up.
 > 
 > 2 option for gpio.h:
 > - use #if CONFIG_BOARD... in gpio.h file  to show differences (also
 > macbook21 gpio.c).
 > - change gpio.h into gpio.c and include those accordingly in
 > Makefile.inc (my preference if differences are too large).

I'll have a look at this option too. Currently I just replicated the t400/t500/r400 pattern, pointed out by the other reviewer.

Thank you again. On my way...

-- 
To view, visit https://review.coreboot.org/19106
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98f774b882817898815ad039efeba1d71ee98ec3
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No