[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: turned into a variant of x201
Arthur Heymans (Code Review)
gerrit at coreboot.org
Tue Apr 4 13:51:54 CEST 2017
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19106 )
Change subject: mainboard/lenovo/t410: turned into a variant of x201
......................................................................
Patch Set 1:
I think it's better to squash those together in one commit.
Also no need to create different dirs for this. look at how macbook21 Kconfig are set up.
2 option for gpio.h:
- use #if CONFIG_BOARD... in gpio.h file to show differences (also macbook21 gpio.c).
- change gpio.h into gpio.c and include those accordingly in Makefile.inc (my preference if differences are too large).
--
To view, visit https://review.coreboot.org/19106
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f774b882817898815ad039efeba1d71ee98ec3
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
More information about the coreboot-gerrit
mailing list