[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: Add new port

[Ani Chang (Code Review)]

Ani Chang has posted comments on this change. ( https://review.coreboot.org/19079 )

Change subject: mainboard/lenovo/t410: Add new port
......................................................................


Patch Set 3:

> > > For variant with (almost) identical code: https://review.coreboot.org/#/c/17894/5/src/mainboard/apple/macbook21/Kconfig.name
 > > > and https://review.coreboot.org/#/c/17894/5/src/mainboard/apple/macbook21/Kconfig
 > > >
 > > > Are you sure GPIOs are set up the same?
 > >
 > 
 > You can check with (in util) inteltool -g how GPIOs are set and
 > compare with mb/x201/gpio.h. If you are having trouble to
 > understand those, you can paste them here or look up datasheets ;)

I don't understand how to map gpio.h and the output of inteltool -g (attached). I am having weird issues with the SD card; it is always mounted read-only, it may be one of those gpios ... 

T410 GPIOs:

Northbridge: 8086:0044 (1st generation (Westmere family) Core Processor)
Southbridge: 8086:3b07 (QM57)
IGD: 8086:0046 (unknown)

============= GPIOS =============

GPIOBASE = 0x0480 (IO)

gpiobase+0x0000: 0x3963a5ff (GPIO_USE_SEL)
gpiobase+0x0004: 0xc7bf6aff (GP_IO_SEL)
gpiobase+0x0008: 0x00000000 (RESERVED)
gpiobase+0x000c: 0x7afaff9b (GP_LVL)
gpiobase+0x0010: 0x00000000 (RESERVED)
gpiobase+0x0014: 0x00000000 (RESERVED)
gpiobase+0x0018: 0x00000000 (GPO_BLINK)
gpiobase+0x001c: 0x00000000 (GP_SER_BLINK)
gpiobase+0x0020: 0x00080000 (GP_SB_CMDSTS)
gpiobase+0x0024: 0x00000000 (GP_SB_DATA)
gpiobase+0x0028: 0x0000     (GPI_NMI_EN)
gpiobase+0x002a: 0x0000     (GPI_NMI_STS)
gpiobase+0x002c: 0x000020c6 (GPI_INV)
gpiobase+0x0030: 0x027706fe (GPIO_USE_SEL2)
gpiobase+0x0034: 0x1f01f9f5 (GP_IO_SEL2)
gpiobase+0x0038: 0xfde8ff9f (GP_LVL2)
gpiobase+0x003c: 0x00000000 (RESERVED)
gpiobase+0x0040: 0x00000000 (GPIO_USE_SEL3)
gpiobase+0x0044: 0x00000f00 (GP_IO_SEL3)
gpiobase+0x0048: 0x00000f0f (GPIO_LVL3)
gpiobase+0x004c: 0x00000000 (RESERVED)
gpiobase+0x0050: 0x00000000 (RESERVED)
gpiobase+0x0054: 0x00000000 (RESERVED)
gpiobase+0x0058: 0x00000000 (RESERVED)
gpiobase+0x005c: 0x00000000 (RESERVED)
gpiobase+0x0060: 0x01000000 (GP_RST_SEL1)
gpiobase+0x0064: 0x00000000 (GP_RST_SEL2)
gpiobase+0x0068: 0x00000000 (GP_RST_SEL3)
gpiobase+0x006c: 0x00000000 (RESERVED)
gpiobase+0x0070: 0x00000000 (RESERVED)
gpiobase+0x0074: 0x00000000 (RESERVED)
gpiobase+0x0078: 0x00000000 (RESERVED)
gpiobase+0x007c: 0x00000000 (RESERVED)

-- 
To view, visit https://review.coreboot.org/19079
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80ea9ea4787c6cacf0640ce828bf083d616c91f9
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No