[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/t410: Add new port

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19079 )

Change subject: mainboard/lenovo/t410: Add new port
......................................................................


Patch Set 3:

> > For variant with (almost) identical code: https://review.coreboot.org/#/c/17894/5/src/mainboard/apple/macbook21/Kconfig.name
 > > and https://review.coreboot.org/#/c/17894/5/src/mainboard/apple/macbook21/Kconfig
 > >
 > > Are you sure GPIOs are set up the same?
 > 
 > No, I am not sure. I don't own a x201. The only LEDs not working
 > same of original bios from Lenovo are the ones on the lid (ie:
 > charge and sleep); but the same "bug" appears on the x220. It may
 > be due to the EC controller, rather than the main firmware.

You can check with (in util) inteltool -g how GPIOs are set and compare with mb/x201/gpio.h. If you are having trouble to understand those, you can paste them here or look up datasheets ;)

I think suspend light is indeed EC related (or at least is so on x60 and x200).

-- 
To view, visit https://review.coreboot.org/19079
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80ea9ea4787c6cacf0640ce828bf083d616c91f9
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Ani Chang <anichang at protonmail.ch>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No