[coreboot-gerrit] Patch set updated for coreboot: mainboard/google/reef: Add all DMIC endpoints
Sathyanarayana Nujella (sathyanarayana.nujella@intel.com)
gerrit at coreboot.org
Wed Nov 30 20:59:07 CET 2016
Sathyanarayana Nujella (sathyanarayana.nujella at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17660
-gerrit
commit 7a240ce54b1ee5fca3286e8e8410ab2e3cadc021
Author: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Date: Wed Nov 30 10:11:55 2016 -0800
mainboard/google/reef: Add all DMIC endpoints
Independent of Board DMIC configuration, add all DMIC points
i.e. add DMIC-1ch, DMIC-2ch, DMIC-4ch endpoints.
This allows flexibility to userspace to open capture devices as needed.
This is a temporary fix; once upper layers support choosing
particular channels from 4-ch PCM stream, we will limit exposing only
DMIC-4ch endpoint.
BUG=chrome-os-partner:60444
BRANCH=none
TEST=Verify All DMIC blobs are included
Change-Id: I9729a3570c0668f3da4e7986291ebad6fe1de47a
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
---
src/mainboard/google/reef/variants/baseboard/nhlt.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/mainboard/google/reef/variants/baseboard/nhlt.c b/src/mainboard/google/reef/variants/baseboard/nhlt.c
index 86da039..d44d599 100644
--- a/src/mainboard/google/reef/variants/baseboard/nhlt.c
+++ b/src/mainboard/google/reef/variants/baseboard/nhlt.c
@@ -22,18 +22,15 @@
void __attribute__((weak)) variant_nhlt_init(struct nhlt *nhlt)
{
- if (gpio_get(DMIC_CONFIG_PIN) == 1) {
- /* 1-dmic configuration */
- if (!nhlt_soc_add_dmic_array(nhlt, 1))
- printk(BIOS_ERR, "Added 1CH DMIC array.\n");
- } else {
- /* 4-dmic configuration */
- if (!nhlt_soc_add_dmic_array(nhlt, 2))
- printk(BIOS_ERR, "Added 2CH DMIC array.\n");
-
- if (!nhlt_soc_add_dmic_array(nhlt, 4))
- printk(BIOS_ERR, "Added 4CH DMIC array.\n");
- }
+ /* 1-dmic configuration */
+ if (!nhlt_soc_add_dmic_array(nhlt, 1))
+ printk(BIOS_ERR, "Added 1CH DMIC array.\n");
+ /* 2-dmic configuration */
+ if (!nhlt_soc_add_dmic_array(nhlt, 2))
+ printk(BIOS_ERR, "Added 2CH DMIC array.\n");
+ /* 4-dmic configuration */
+ if (!nhlt_soc_add_dmic_array(nhlt, 4))
+ printk(BIOS_ERR, "Added 4CH DMIC array.\n");
/* Dialog for Headset codec.
* Headset codec is bi-directional but uses the same configuration
* settings for render and capture endpoints.
More information about the coreboot-gerrit
mailing list