[coreboot-gerrit] Patch merged into coreboot/master: nb/intel/i945/gma: Declare count variable outside 'for' loop

gerrit at coreboot.org gerrit at coreboot.org
Tue Nov 29 17:21:34 CET 2016


the following patch was just integrated into master:
commit 533a3859c8306772e585a734361bc2f0b242c075
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Nov 27 22:17:44 2016 +0100

    nb/intel/i945/gma: Declare count variable outside 'for' loop
    
    Building an image for the Lenovo X60 on Debian 8.5 (jessie) with GCC 4.9.2,
    compilation fails with the error below.
    
    ```
    $ gcc --version
    gcc (Debian 4.9.2-10) 4.9.2
    […]
    $ make # lenovo/x60 with native graphics initialization
    […]
        CC         ramstage/northbridge/intel/i945/gma.o
    src/northbridge/intel/i945/gma.c: In function 'probe_edid':
    src/northbridge/intel/i945/gma.c:570:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
      for (int i = 0; i < 8; i++) {
      ^
    src/northbridge/intel/i945/gma.c:570:2: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
    Makefile:316: recipe for target 'build/ramstage/northbridge/intel/i945/gma.o' failed
    make: *** [build/ramstage/northbridge/intel/i945/gma.o] Error 1
    ```
    
    Fix this by declaring the count variable outside the 'for' loop.
    
    Change-Id: Icf69337ee46c86bafc4e1320fd99f8f8f5155bfe
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: https://review.coreboot.org/17623
    Tested-by: build bot (Jenkins)
    Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>


See https://review.coreboot.org/17623 for details.

-gerrit



More information about the coreboot-gerrit mailing list