[coreboot-gerrit] Patch set updated for coreboot: google/parrot: Fix keyboard interrupts, DSDT
Matt DeVillier (matt.devillier@gmail.com)
gerrit at coreboot.org
Sun Nov 20 22:13:24 CET 2016
Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17017
-gerrit
commit b191c86663753e2655a407dc89395e75cabb2975
Author: Prabal Saha <coolstarorganization at gmail.com>
Date: Thu Oct 13 07:52:23 2016 -0700
google/parrot: Fix keyboard interrupts, DSDT
Commit 967cd9a [ChromeOS: fix Kconfig dependencies] broke keyboard
interrupts on parrot by making SERIRQ_CONTINUOUS_MODE conditional on
CONFIG_CHROMEOS, which it should not be; fix by moving back under main
board specific options config.
Additionally, Windows [8/8.1/10] fails to enumerate the keyboard when its
ACPI entry is located under the SIO device, since 1) the SIO device is missing
a _HID entry, and 2) the keyboard is actually an LPC device, not a SIO one.
Change-Id: Ia69e9b326001d2026b15b4ec03c94f7d03c8a700
Signed-off-by: Prabal Saha <coolstarorganization at gmail.com>
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
src/ec/compal/ene932/acpi/superio.asl | 4 ++--
src/mainboard/google/parrot/Kconfig | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/ec/compal/ene932/acpi/superio.asl b/src/ec/compal/ene932/acpi/superio.asl
index 8eba623..8723aee 100644
--- a/src/ec/compal/ene932/acpi/superio.asl
+++ b/src/ec/compal/ene932/acpi/superio.asl
@@ -18,9 +18,9 @@
Device (SIO) {
Name (_UID, 0)
Name (_ADR, 0)
+}
// Keyboard or AUX port (a.k.a Mouse)
#ifdef SIO_EC_ENABLE_PS2K
#include <drivers/pc80/pc/ps2_controller.asl>
-#endif
-}
+#endif
\ No newline at end of file
diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig
index 974c58f..7b6b49b 100644
--- a/src/mainboard/google/parrot/Kconfig
+++ b/src/mainboard/google/parrot/Kconfig
@@ -14,13 +14,12 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select MAINBOARD_HAS_CHROMEOS
select MAINBOARD_HAS_LPC_TPM
select INTEL_INT15
+ # Workaround for EC/KBC IRQ1.
+ select SERIRQ_CONTINUOUS_MODE
config CHROMEOS
select VBOOT_VBNV_CMOS
- # Workaround for EC/KBC IRQ1.
- select SERIRQ_CONTINUOUS_MODE
-
config MAINBOARD_DIR
string
default google/parrot
More information about the coreboot-gerrit
mailing list