[coreboot-gerrit] New patch to review for coreboot: AMD sb600: Fix PCI ID error

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sun Nov 20 02:57:25 CET 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17513

-gerrit

commit d3f36a13d762f0e102ec1e01037a2490d8b0a576
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Nov 19 22:57:03 2016 +0200

    AMD sb600: Fix PCI ID error
    
    Broken since February 2008, looking for incorrect PCI VENDOR.
    
    Change-Id: I6935683a8a7428ca9b2e90bcc0a090c3865ffd33
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/southbridge/amd/sb600/hda.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/southbridge/amd/sb600/hda.c b/src/southbridge/amd/sb600/hda.c
index 88b242e..bb2b2b1 100644
--- a/src/southbridge/amd/sb600/hda.c
+++ b/src/southbridge/amd/sb600/hda.c
@@ -271,9 +271,7 @@ static void hda_init(struct device *dev)
 	pm_iowrite(0x59, 0xB);
 
 	/* Find the SMBus */
-	/* FIXME: Need to find out why the call below crashes. */
-	/*sm_dev = dev_find_device(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_ATI_SB600_SM, 0);*/
-	sm_dev = dev_find_slot(0, PCI_DEVFN(0x14, 0));
+	sm_dev = dev_find_device(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SB600_SM, 0);
 
 	/* Set routing pin - SMBus ExtFunc (0xf8/0xfc) */
 	pci_write_config32(sm_dev, 0xf8, 0x00);



More information about the coreboot-gerrit mailing list