[coreboot-gerrit] New patch to review for coreboot: AMD rs780: Fix PCI ID error and namespace

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sun Nov 20 02:57:15 CET 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17512

-gerrit

commit 458901531cf7fd11db14c40a28b4c285cd17b71c
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Nov 19 22:57:03 2016 +0200

    AMD rs780: Fix PCI ID error and namespace
    
    Checked logs of two boards with SOUTHBRIDGE_AMD_RS780 with
    neither of them showing "pcie_init in rs780_ht.c" line,
    suggesting the PCI vendor ID was indeed incorrect.
    
    Numbering of RS780x_INT_GFX parts also suggests the IDs
    changed here belong to VENDOR_ID_ATI namespace.
    
    Change-Id: Ib79fafd7e35a2f84b89f6ecc9246519f4402da4c
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/include/device/pci_ids.h   | 22 +++++++++++-----------
 src/southbridge/amd/rs780/ht.c |  4 ++--
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index de978b0..9fb17c9 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -387,17 +387,17 @@
 #define PCI_DEVICE_ID_ATI_RS690MT_INT_GFX	0x791f
 #define PCI_DEVICE_ID_ATI_RS740_INT_GFX		0x796e
 
-#define PCI_DEVICE_ID_AMD_RS780_HT		0x9600
-#define PCI_DEVICE_ID_AMD_RS780_PCIE		0x9602
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV2	0x9603
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV3	0x960B
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV4	0x9604
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV5	0x9605
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV6	0x9606
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV7	0x9607
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV9	0x9608
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV10	0x9609
-#define PCI_DEVICE_ID_AMD_RS780_PCIE_DEV8	0x960A
+#define PCI_DEVICE_ID_ATI_RS780_HT		0x9600
+#define PCI_DEVICE_ID_ATI_RS780_PCIE		0x9602
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV2	0x9603
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV3	0x960B
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV4	0x9604
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV5	0x9605
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV6	0x9606
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV7	0x9607
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV9	0x9608
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV10	0x9609
+#define PCI_DEVICE_ID_ATI_RS780_PCIE_DEV8	0x960A
 #define PCI_DEVICE_ID_ATI_RS780_INT_GFX		0x9610
 #define PCI_DEVICE_ID_ATI_RS780C_INT_GFX	0x9611
 #define PCI_DEVICE_ID_ATI_RS780M_INT_GFX	0x9612
diff --git a/src/southbridge/amd/rs780/ht.c b/src/southbridge/amd/rs780/ht.c
index 4bf0bef..a1242d6 100644
--- a/src/southbridge/amd/rs780/ht.c
+++ b/src/southbridge/amd/rs780/ht.c
@@ -81,6 +81,6 @@ static struct device_operations ht_ops = {
 
 static const struct pci_driver ht_driver __pci_driver = {
 	.ops = &ht_ops,
-	.vendor = PCI_VENDOR_ID_AMD,
-	.device = PCI_DEVICE_ID_AMD_RS780_HT,
+	.vendor = PCI_VENDOR_ID_ATI,
+	.device = PCI_DEVICE_ID_ATI_RS780_HT,
 };



More information about the coreboot-gerrit mailing list