[coreboot-gerrit] New patch to review for coreboot: [not for merge]nb/intel/sandybridge/raminit: Fix wr_t for mr0

Patrick Rudolph (siro@das-labor.org) gerrit at coreboot.org
Sat Nov 19 16:17:00 CET 2016


Patrick Rudolph (siro at das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17503

-gerrit

commit 90731333ec3f62235eafe32e4066e2387f82db64
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Sat Nov 19 15:50:46 2016 +0100

    [not for merge]nb/intel/sandybridge/raminit: Fix wr_t for mr0
    
    The spec requires to set any value that is equal or greater
    than tWR. Use the next possible value instead of 0, which
    translates to 16 cycles.
    
    Untested.
    
    Change-Id: I7d93eadc46a5a24f6026256bd09f7dc1b5d5b8a9
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
 src/northbridge/intel/sandybridge/raminit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index a34fbfc..6cd6eea 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -1445,7 +1445,7 @@ static void write_mrreg(ramctr_timing *ctrl, int channel, int slotrank,
 static u32 make_mr0(ramctr_timing * ctrl, u8 rank)
 {
 	u16 mr0reg;
-	static const u8 mch_wr_t[12] = { 1, 2, 3, 4, 0, 5, 0, 6, 0, 7, 0, 0 };
+	static const u8 mch_wr_t[12] = { 1, 2, 3, 4, 5, 5, 6, 6, 7, 7, 0, 0 };
 
 	mr0reg = 0;
 	/* DLL Reset - self clearing - set after CLK frequency has been changed */



More information about the coreboot-gerrit mailing list