[coreboot-gerrit] New patch to review for coreboot: arch/x86 GDT: Fix orphan debug output

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sat Nov 19 15:45:07 CET 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17500

-gerrit

commit 2f91572ffe065eee004720bd9768f7a64f63d35c
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Nov 19 16:39:10 2016 +0200

    arch/x86 GDT: Fix orphan debug output
    
    On S3 resume path, CBMEM_ID_GDT already exists but we only printed
    the final "ok" string. Always tell GDT is about to be moved.
    
    Change-Id: Ic91c5389cf4d47d28a6c54db152c18541c413bc1
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/arch/x86/gdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/gdt.c b/src/arch/x86/gdt.c
index fe14155..982b8ae 100644
--- a/src/arch/x86/gdt.c
+++ b/src/arch/x86/gdt.c
@@ -45,9 +45,9 @@ static void move_gdt(int is_recovery)
 			printk(BIOS_ERR, "Error: Could not relocate GDT.\n");
 			return;
 		}
-		printk(BIOS_DEBUG, "Moving GDT to %p...", newgdt);
 		memcpy((void*)newgdt, &gdt, num_gdt_bytes);
 	}
+	printk(BIOS_DEBUG, "Moving GDT to %p...", newgdt);
 
 	gdtarg.base = (uintptr_t)newgdt;
 	gdtarg.limit = num_gdt_bytes - 1;



More information about the coreboot-gerrit mailing list