[coreboot-gerrit] New patch to review for coreboot: intel sandy/ivy: Change CRC used to detect DIMM replacement

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Fri Nov 18 21:06:28 CET 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17487

-gerrit

commit 00074676f5f221a90316255b4a6a461966876d37
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Nov 18 18:52:04 2016 +0200

    intel sandy/ivy: Change CRC used to detect DIMM replacement
    
    Switch to use CRC of unique identifier section SPD[117..128],
    remaining area of SPD data is ignored.
    
    Change-Id: If4b43183f99f5f911ae6c311b43c29a72b9922e2
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/northbridge/intel/sandybridge/raminit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index 46dc7c7..79fe12b 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -351,7 +351,7 @@ static int verify_crc16_spds_ddr3(spd_raw_data *spd, ramctr_timing *ctrl)
 		for (slot = 0; slot < NUM_SLOTS; slot++) {
 			spd_slot = 2 * channel + slot;
 			match &= ctrl->spd_crc[channel][slot] ==
-					spd_ddr3_calc_crc(spd[spd_slot], sizeof(spd_raw_data));
+					spd_ddr3_calc_unique_crc(spd[spd_slot], sizeof(spd_raw_data));
 		}
 	}
 	return match;
@@ -411,7 +411,7 @@ static void dram_find_spds_ddr3(spd_raw_data *spd, ramctr_timing *ctrl)
 
 			/* fill in CRC16 for MRC cache */
 			ctrl->spd_crc[channel][slot] =
-					spd_ddr3_calc_crc(spd[spd_slot], sizeof(spd_raw_data));
+					spd_ddr3_calc_unique_crc(spd[spd_slot], sizeof(spd_raw_data));
 
 			if (dimm->dimm[channel][slot].dram_type != SPD_MEMORY_TYPE_SDRAM_DDR3) {
 				// set dimm invalid



More information about the coreboot-gerrit mailing list