[coreboot-gerrit] New patch to review for coreboot: google/snappy: update timing of sdmode toggling

Wisley Chen (wisley.chen@quantatw.com) gerrit at coreboot.org
Thu Nov 10 15:27:42 CET 2016


Wisley Chen (wisley.chen at quantatw.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17361

-gerrit

commit 63a58c8b75f615a386030be4ea1541ed9175e8ef
Author: Wisley Chen <wisley.chen at quantatw.com>
Date:   Thu Nov 10 08:54:56 2016 -0500

    google/snappy: update timing of sdmode toggling
    
    Maxim98357a speaker amp requires BCLK & SFRM to be active
    and stable before it is unmuted. If there is a BLCK and no
    SFRM, it results in a pop sound.
    
    sdmode_delay property already exists which facilitates this
    configuration. This patch updates "sdmode_delay" to avoid
    pop sound.
    
    BUG=chrome-os-partner:59034
    BRANCH=master
    TEST=emerge-snappy coreboot chromeos-bootimage
    
    Change-Id: Ic9095ae6812ba822c760229e69f5b27c6c244cdf
    Signed-off-by: Wisley Chen <wisley.chen at quantatw.com>
---
 src/mainboard/google/reef/variants/snappy/devicetree.cb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mainboard/google/reef/variants/snappy/devicetree.cb b/src/mainboard/google/reef/variants/snappy/devicetree.cb
index 43ec2ed..989acd9 100644
--- a/src/mainboard/google/reef/variants/snappy/devicetree.cb
+++ b/src/mainboard/google/reef/variants/snappy/devicetree.cb
@@ -85,6 +85,7 @@ chip soc/intel/apollolake
 		device pci 0e.0 on	# - Audio
 			chip drivers/generic/max98357a
 				register "sdmode_gpio" =  "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
+				register "sdmode_delay" = "5"
 				device generic 0 on end
 			end
 		end



More information about the coreboot-gerrit mailing list