[coreboot-gerrit] Patch merged into coreboot/master: rockchip/rk3399: sdram: Reset system if switch to index1 fails

gerrit at coreboot.org gerrit at coreboot.org
Wed Nov 2 17:31:10 CET 2016


the following patch was just integrated into master:
commit 13acd35d6fa2623dce970acae9296b80a75ed2a3
Author: Lin Huang <hl at rock-chips.com>
Date:   Sun Oct 16 13:24:08 2016 -0700

    rockchip/rk3399: sdram: Reset system if switch to index1 fails
    
    Near the end of DDR initialization, the system switches to the index1
    configuration. Sometimes this failed and a status bit that coreboot was
    waiting for was never set, hanging the system.
    
    Instead, give the system 100ms to reach the new configuration or reboot
    it, which generally fixes the issue. Also reset when training the index1
    configuration fails.
    
    BUG=chrome-os-partner:57988
    BRANCH=None
    TEST=The error condition now leads to a reboot of coreboot which
    recovers the system, instead of hanging.
    
    Change-Id: Icb4270369102ff7a4ce91b0677e04b4eb10f1204
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: ca250d0628ea3b6b39d5131246eaba68637c5140
    Original-Change-Id: Id6e8936d90e54b733ac327f8476d744b45639232
    Original-Signed-off-by: Lin Huang <hl at rock-chips.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/399681
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://review.coreboot.org/17106
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/17106 for details.

-gerrit



More information about the coreboot-gerrit mailing list