[coreboot-gerrit] Patch merged into coreboot/master: intel/{skylake, apollolake}: Enable signalling of error condition

gerrit at coreboot.org gerrit at coreboot.org
Wed Nov 2 17:29:42 CET 2016


the following patch was just integrated into master:
commit 84164603188175abd2a3d8eeab1adc5efc33330f
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Fri Jul 29 18:37:56 2016 +0200

    intel/{skylake,apollolake}: Enable signalling of error condition
    
    Testing for "devfn < 0" on an unsigned doesn't work, and i2c_bus_to_devfn
    returns an int (with -1 for "error"), so use int for devfn.
    
    Adapt Change-Id I7d1cdb6af4140f7dc322141c0c018d8418627434 to fix more
    instances.
    
    Change-Id: I001a9b484a68e018798a65c0fae11f8df7d9f564
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1357450, #1357449
    Reviewed-on: https://review.coreboot.org/17054
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/17054 for details.

-gerrit



More information about the coreboot-gerrit mailing list