[coreboot-gerrit] New patch to review for coreboot: WIP: do not use StackBase in Apollolake FSP

[Bora Guvendik (bora.guvendik@intel.com)]

Bora Guvendik (bora.guvendik at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14803

-gerrit

commit 9dc1f9ea201c54771933fb80d5a7a35a98387664
Author: Andrey Petrov <andrey.petrov at intel.com>
Date:   Fri Apr 15 21:32:30 2016 -0700

    WIP: do not use StackBase in Apollolake FSP
    
    Currently, StackBase UPD doesn't work and changing it leads to a crash.
    Not setting it leaves default value that works.
    
    BUG=chrome-os-partner:51844
    BRANCH=none
    TEST=boots to chrome OS
    
    Change-Id: Id3f3ea9a834d0c04a8381938535109d6a729cca2
    Signed-off-by: Andrey Petrov <andrey.petrov at intel.com>
---
 src/soc/intel/apollolake/romstage.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c
index 8ec94a7..7dedea9 100644
--- a/src/soc/intel/apollolake/romstage.c
+++ b/src/soc/intel/apollolake/romstage.c
@@ -238,9 +238,12 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd)
 	 * requests.
 	 * TODO: add checks to avoid overlap/conflict of CAR usage.
 	 */
+
+	/* fsp does not work with StackBase modified, so use default */
+#if 0
 	mupd->FspmArchUpd.StackBase = _car_region_end -
 					mupd->FspmArchUpd.StackSize;
-
+#endif
 	arch_upd->Bootmode = FSP_BOOT_WITH_FULL_CONFIGURATION;
 
 	if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) {